Don't 500 on listSourceBindings after source removal#515
Merged
RhysSullivan merged 1 commit intomainfrom May 4, 2026
Merged
Conversation
When the React openApiSourceBindingsAtom revalidates after a source delete (sourceWriteKeys invalidate it before the page unmounts), the store threw StorageError because validateBindingTarget required the source row to exist. That surfaced to the browser as a 500 / Sentry alert even though the delete itself succeeded. Split validateBindingTarget into a scope-stack-only validator used by reads (listSourceBindings, resolveSourceBinding) and the original used by writes (setSourceBinding, removeSourceBinding). A removed source now reads back as [] / null; writes still reject as before.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | abd0769 | Commit Preview URL Branch Preview URL |
May 04 2026, 05:58 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sourceWriteKeysinvalidates the ReactopenApiSourceBindingsAtom(rendered viaOpenApiSourceSummary/EditOpenApiSource). The atom revalidates before unmount, callslistSourceBindings, and the store'svalidateBindingTargetthrewStorageError("source does not exist")— surfacing to the browser as a 500 and a Sentry alert (NODE-CLOUDFLARE-WORKERS-39).[]/nullrather than throw. Writes still need to reject.validateBindingTargetinto a scope-stack-onlyvalidateBindingScopesused bylistSourceBindingsandresolveSourceBinding; keep the existence check on the write paths (setSourceBinding,removeSourceBinding).Test plan
pnpm vitest runinpackages/plugins/openapi— 72/72 passinglistSourceBindings returns [] for a removed source